Improves debug account simulator #3629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eamodio
commented
Sep 28, 2024
eamodio
commented
- Enhanced the UI/UX to be more "stateful" and holistic
- Changes the non-account states to "remove" the account
- Removed the restore command as I added the functionality directly to the main command
eamodio
force-pushed
the
debt/simulator
branch
from
c7dc0a0 to
f95b9b9
Compare
| } | ||
|
|
||
| private onDidChangeSubscription(e: SubscriptionChangeEvent) { | ||
| // TODO is this correct? |
There was a problem hiding this comment.
This ensures that when we log out of our GK account, any connected cloud integrations are disconnected.
There was a problem hiding this comment.
Ah -- Can you update that comment then please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.